Add ARIA attributes for inline search combobox accessibility#664
Merged
Conversation
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update inline search functionality based on feedback
Add ARIA attributes for inline search combobox accessibility
Dec 8, 2025
Member
|
@copilot remove package-lock.json, use pnpm ( |
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Author
Done in commit f61d986:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useId()to generate unique IDsaria-expandedattribute to indicate dropdown statearia-controlsattribute to reference the dropdown listboxaria-activedescendantto indicate currently active optionidto the dropdown elementrole="listbox"to the dropdown for proper semanticsrole="option"andaria-selectedto each optionSummary
All ARIA accessibility attributes have been successfully implemented for the inline search combobox mode. The changes improve screen reader support and follow ARIA best practices for combobox widgets.
Changes in this commit
Security Summary
✅ No security vulnerabilities detected by CodeQL analysis.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.